[v8-dev] Re: Debug: parameterize 'step over' action with a frame where the step must be performed (issue 23533015)

2013-09-08 Thread prybin
Committed patchset #2 manually as r16581 (presubmit successful). https://codereview.chromium.org/23533015/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Debug: parameterize 'step over' action with a frame where the step must be performed (issue 23533015)

2013-09-06 Thread yangguo
On 2013/09/05 16:58:21, Peter.Rybin wrote: Thank you. Please feel free to ask if you want any comments about the change. https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): https://codereview.chromium.org/23533015/diff/1/src/debug-debug

[v8-dev] Re: Debug: parameterize 'step over' action with a frame where the step must be performed (issue 23533015)

2013-09-05 Thread yangguo
Not quite done yet. First round of comments. I'll continue tomorrow. https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js#newcode960 src/debug-debugger.js:960: ExecutionSta

[v8-dev] Re: Debug: parameterize 'step over' action with a frame where the step must be performed (issue 23533015)

2013-09-05 Thread prybin
Thank you. Please feel free to ask if you want any comments about the change. https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js#newcode960 src/debug-debugger.js:960: E