Thanks a lot, Zaheer. Landing it.
http://codereview.chromium.org/6462029/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
hi Anton, Addressed comments. could you take another look.
Thanks.
http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc#newcode1245
src/arm/stub-cache-arm.cc:1245:
Almost LGTM, let's do last round and I'll land it
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc#newcode1534
src/arm/simulator-arm.cc:1534: typedef v8::Handle
(*
Thanks Anton, Serya for your comments. Please review the latest patch.
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc#newcode1534
src/arm/simulator-arm.cc:1534:
http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc#newcode1260
src/arm/stub-cache-arm.cc:1260: __ push(name_reg);
__ Push(receiver, scratch3, name_reg) (or at leas
Thanks a lot for working on this!
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc#newcode1534
src/arm/simulator-arm.cc:1534: typedef v8::Handle
(*SimulatorRuntime
