[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc#newcode255 src/arm/full-codegen-arm.cc:255: __ cmp(r1,

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/1196193014/diff/40001/src/arm/full-codegen-arm.cc#newcode255 src/arm/full-codegen-arm.cc:255: __ cmp(r1,

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

LGTM https://codereview.chromium.org/1196193014/diff/20001/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/1196193014/diff/20001/src/arm/builtins-arm.cc#newcode813 src/arm/builtins-arm.cc:813: __ ldr(r1, MemOperand(sp, kPointerSize)); Add comment

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

Yup, passes all tests https://codereview.chromium.org/1196193014/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/1196193014/diff/1/src/ia32/full-codegen-ia32.cc#newcode269 src/ia32/full-codegen-ia32.cc:269: SetVar(new_target_var,

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

https://codereview.chromium.org/1196193014/diff/1/src/ia32/builtins-ia32.cc File src/ia32/builtins-ia32.cc (right): https://codereview.chromium.org/1196193014/diff/1/src/ia32/builtins-ia32.cc#newcode556 src/ia32/builtins-ia32.cc:556: __ mov(ebx, Operand(esp, kPointerSize)); This could use a

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

Thanks. Does this pass all the tests on ia32? https://codereview.chromium.org/1196193014/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/1196193014/diff/1/src/ia32/full-codegen-ia32.cc#newcode269

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

Comments addressed, landing. https://codereview.chromium.org/1196193014/diff/1/src/ia32/builtins-ia32.cc File src/ia32/builtins-ia32.cc (right): https://codereview.chromium.org/1196193014/diff/1/src/ia32/builtins-ia32.cc#newcode556 src/ia32/builtins-ia32.cc:556: __ mov(ebx, Operand(esp,

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

Committed patchset #3 (id:40001) https://codereview.chromium.org/1196193014/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

Patchset 3 (id:??) landed as https://crrev.com/8196c28a94f62dec026f2b564ba81d690a4ed593 Cr-Commit-Position: refs/heads/master@{#29238} https://codereview.chromium.org/1196193014/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Do not add extra argument for new.target (issue 1196193014 by dslo...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196193014/40001 https://codereview.chromium.org/1196193014/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are