[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/d281688ae571bc2e5a302ee32a503be32c4ae720 Cr-Commit-Position: refs/heads/master@{#30189} https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295093002/20001 https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295093002/20001 https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread commit-...@chromium.org via codereview.chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files. h

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread cbruni
lgtm https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Do not use js builtins object when constructing an error. (issue 1295093002 by yang...@chromium.org)

2015-08-17 Thread yangguo
This follows the pattern of putting the function into a native context slot instead of retrieving it from the js builtins object. Also removes some dead code. https://codereview.chromium.org/1295093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---