[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

Committed patchset #6 manually as r21697. https://codereview.chromium.org/306463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gr

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

https://codereview.chromium.org/306463002/diff/80001/src/isolate.h File src/isolate.h (right): https://codereview.chromium.org/306463002/diff/80001/src/isolate.h#newcode1182 src/isolate.h:1182: // Propagate pending exception message to the external try-catch. nit: s/external try-catch/v8::TryCa

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

LGTM from my end as well. Just nits. Sorry for the delay. https://codereview.chromium.org/306463002/diff/80001/src/isolate.h File src/isolate.h (right): https://codereview.chromium.org/306463002/diff/80001/src/isolate.h#newcode1182 src/isolate.h:1182: // Propagate pending exception message to t

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

LGTM from my side, but please wait for Michael to take a look. I'll ask him later to do that. https://codereview.chromium.org/306463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

On 2014/06/02 15:21:16, Yang wrote: Looking good. I got some comments. And I would like to add mstarzinger@ for a second opinion. https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/6

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc File src/isolate.cc (left): https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#oldcode1157 src/isolate.cc:1157: if (!is_catchable_by_javascript(pending_exception())) { Looking at this once again I

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

Looking good. I got some comments. And I would like to add mstarzinger@ for a second opinion. https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1154 src/isol

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

yangguo@, Could you please have a look on this? https://chromiumcodereview.appspot.com/306463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

lgtm https://chromiumcodereview.appspot.com/306463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

On 2014/06/02 09:19:55, vsevik wrote: https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc#newcode1730 src/isolate.cc:1730: bool has_externaly_caught = HasExternallyCa

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/20001/src/isolate.cc#newcode1730 src/isolate.cc:1730: bool has_externaly_caught = HasExternallyCaught(); has_external_try_catch https://c

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

On 2014/05/28 18:00:31, vsevik wrote: Can we add a test? Yes, we can. Done. https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1727 src/isolate.cc:1727: // Return

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 306463002)

Can we add a test? https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1727 src/isolate.cc:1727: // Return true. if we don't pending message and can remove it Either com