[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 321763002)

Committed patchset #3 manually as r21755 (presubmit successful). https://codereview.chromium.org/321763002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 321763002)

On 2014/06/10 14:57:45, Yang wrote: lgtm with comment. https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc#newcode1732 src/isolate.cc:1732: if (is_finally_on_top) { can't we jus

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 321763002)

lgtm with comment. https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc#newcode1732 src/isolate.cc:1732: if (is_finally_on_top) { can't we just if (IsFinallyOnTop()) ... ? https://co

[v8-dev] Re: Don't clear exception pending message if we have externally TryCatch and finally on top of stack. (issue 321763002)

This patch continues https://codereview.chromium.org/306463002/ First patch set is last reviewed patch set from https://codereview.chromium.org/306463002/ Second patch set have fixed bug with ASSERT(!handler->is_catch()) in Isolate::IsFinallyOnTop(). It is essentially to not check IsFinallyOnTop