[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

Committed patchset #4 manually as r20503 (presubmit successful). https://codereview.chromium.org/223533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

lgtm https://codereview.chromium.org/223533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

https://codereview.chromium.org/223533002/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251 src/objects.cc:7251: explicit IntrusiveMapTransitionIterator( On 2014/04/03 13:07:37, Michael Starzinger wrote: nit: D

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

LGTM (👀👍). I like it. Just a couple of nits. Only one real suggestion about the ChildIteratorStart function. https://codereview.chromium.org/223533002/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/223533002/diff/20001/src/objects.cc#newcode7251 src/obj

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

Overall looks good to me, but can you please ASSERT that all constructors are actually equal? https://codereview.chromium.org/223533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Goog

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

The back pointer simplification does not work, since maps in the prototype transition array do not point back to the parent. https://codereview.chromium.org/223533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because y

[v8-dev] Re: Don't overwrite transition array map while iterating over the transition tree. (issue 223533002)

I think I can also take advantage of the back pointer - no need to overwrite the map of the map. WDYT? https://codereview.chromium.org/223533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to