Re: [v8-dev] Re: ES6: Make Map/Set constructors support iterable values (issue 464093002 by a...@chromium.org)

2014-08-13 Thread Dmitry Lomov
Still feels fragile to me. I'd support cherry-picking; let's keep our eye on where the branch ends up. On Wed, Aug 13, 2014 at 3:42 AM, Erik Arvidsson a...@chromium.org wrote: This is actually going to be OK in release mode. The function that gets called takes Object and already handles Name

[v8-dev] Re: ES6: Make Map/Set constructors support iterable values (issue 464093002 by a...@chromium.org)

2014-08-13 Thread dslomov
lgtm https://codereview.chromium.org/464093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: ES6: Make Map/Set constructors support iterable values (issue 464093002 by a...@chromium.org)

2014-08-13 Thread arv
Committed patchset #2 manually as 23108 (presubmit successful). https://codereview.chromium.org/464093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: ES6: Make Map/Set constructors support iterable values (issue 464093002 by a...@chromium.org)

2014-08-12 Thread adamk
lgtm; seems like we might want to cherry-pick this whole thing into whatever ends up being M38 https://codereview.chromium.org/464093002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the

Re: [v8-dev] Re: ES6: Make Map/Set constructors support iterable values (issue 464093002 by a...@chromium.org)

2014-08-12 Thread Erik Arvidsson
This is actually going to be OK in release mode. The function that gets called takes Object and already handles Name correctly. On Aug 12, 2014 7:39 PM, ad...@chromium.org wrote: lgtm; seems like we might want to cherry-pick this whole thing into whatever ends up being M38