On 2014/01/29 08:29:29, VMuhachev wrote:
On 2014/01/29 07:27:13, Sven Panne wrote:
> Committed patchset #2 manually as r18892 (presubmit successful).
But how will this work after somebody will have implemented iteration over
keys?
What do you mean? The following is the correct ES6 behavior.
On 2014/01/29 07:27:13, Sven Panne wrote:
Committed patchset #2 manually as r18892 (presubmit successful).
But how will this work after somebody will have implemented iteration over
keys?
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Committed patchset #2 manually as r18892 (presubmit successful).
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM. Sven, could you please land this? I don't have access to a suitable
machine right now.
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Updated. PTAL
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
Using key === 0 will work. I didn't think of that. Thanks.
On Jan 27, 2014 11:35 PM, wrote:
> Quick DBC...
>
>
> https://codereview.chromium.org/147143003/diff/30001/src/collection.js
> File src/collection.js (right):
>
> https://codereview.chromium.org/147143003/diff/30001/src/
> collection.js#n
LGTM, modulo Sven's comment
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
Quick DBC...
https://codereview.chromium.org/147143003/diff/30001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/147143003/diff/30001/src/collection.js#newcode51
src/collection.js:51: if (%_IsMinusZero(key)) {
I think using "key === 0" should be more efficient
