[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-06-02 Thread jochen
Committed patchset #2 manually as r21618 (presubmit successful). https://codereview.chromium.org/293363009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread brettw
lgtm https://codereview.chromium.org/293363009/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/293363009/diff/20001/BUILD.gn#newcode986 BUILD.gn:986: component("v8") { CAn you indent the stuff inside the if? https://codereview.chromium.org/293363009/ -- -- v8-dev

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread jochen
ptal I also added the v8 target. the only problem is that the resulting binary doesn't work :) https://codereview.chromium.org/293363009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Goog

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread brettw
On 2014/05/27 15:36:59, jochen wrote: is script = "mksnapshot" enough to make gn build mksnapshot first? And does it figure out itself that it needs to build mksnapshot for the host arch? No and no. To make it build mksnapshot for the host arch before running the action, do: deps = [ ":mks