Committed patchset #2 manually as r21618 (presubmit successful).
https://codereview.chromium.org/293363009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/293363009/diff/20001/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/293363009/diff/20001/BUILD.gn#newcode986
BUILD.gn:986: component("v8") {
CAn you indent the stuff inside the if?
https://codereview.chromium.org/293363009/
--
--
v8-dev
ptal
I also added the v8 target. the only problem is that the resulting binary
doesn't work :)
https://codereview.chromium.org/293363009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Goog
On 2014/05/27 15:36:59, jochen wrote:
is script = "mksnapshot" enough to make gn build mksnapshot first? And
does it
figure out itself that it needs to build mksnapshot for the host arch?
No and no.
To make it build mksnapshot for the host arch before running the action, do:
deps = [ ":mks
