[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-06 Thread dcarney
On 2013/06/06 15:07:39, marja wrote: dcarney@, ptal. I was under the impression that v8 is already post-handlepocalyptic, but doesn't seem so. Maybe this was missed because the code is inside a template which was not instantiated by tests? just use the handle value directly - returnvalue sho

[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-07 Thread marja
alright, made it a friend instead https://codereview.chromium.org/15848010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and s

[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-07 Thread dcarney
lgtm https://codereview.chromium.org/15848010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-07 Thread marja
svenpanne@, ptal https://codereview.chromium.org/15848010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving ema

[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-07 Thread svenpanne
lgtm https://codereview.chromium.org/15848010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Fix ReturnValue::Set. (issue 15848010)

2013-06-07 Thread dcarney
Committed patchset #2 manually as r14999 (presubmit successful). https://codereview.chromium.org/15848010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un