[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1058533007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/e02807ee8a6a254c694da007420ef78b40ac9f62 Cr-Commit-Position: refs/heads/master@{#27848} https://codereview.chromium.org/1058533007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533007/1 https://codereview.chromium.org/1058533007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread svenpanne
lgtm https://codereview.chromium.org/1058533007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread jkummerow
On 2015/04/15 13:02:41, Sven Panne wrote: Uh, oh... Looking at LChunkBuilder::DoMul for ARM64 (only on that platform, why do we do things differently here???), Don't know, don't care, Lithium is deprecated. we already enter undefined-behavior-land when trying to compute the absolute value

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread svenpanne
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4319 src/arm64/lithium-codegen-arm64.cc:4319: DCHECK((right > -kMaxInt

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread jkummerow
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4319 src/arm64/lithium-codegen-arm64.cc:4319: DCHECK((right > -kMaxInt

[v8-dev] Re: Fix a few potential integer negation overflows (issue 1058533007 by jkumme...@chromium.org)

2015-04-15 Thread svenpanne
https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/1058533007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4319 src/arm64/lithium-codegen-arm64.cc:4319: DCHECK((right > -kMaxInt