On 2015/02/13 10:29:36, I haz the power (commit-bot) wrote:
Patchset 4 (id:??) landed as
https://crrev.com/2cfebcf92e8518f9c970ce72d2c4fabfae4e1e06
Cr-Commit-Position: refs/heads/master@{#26636}
Thank you for taking care of this!
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing
Committed patchset #4 (id:80001)
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Patchset 4 (id:??) landed as
https://crrev.com/2cfebcf92e8518f9c970ce72d2c4fabfae4e1e06
Cr-Commit-Position: refs/heads/master@{#26636}
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/920993003/80001
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/920993003/60001
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
comments addressed.
PTAL
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
Actually, I've been chatting with Ilya and I think the conditional
interface is
not the way to go. I've asked him to clean up the test to use the style of
#ifdef VERIFY_HEAP + flag checking that is used elsewhere in the runtime for
heap verification.
https://codereview.chromium.org/920993003/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/920993003/20001
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
LGTM, although I'm not totally convinced that this is enough. Conditional
interfaces are a bad idea, and this #ifdef horror is the price we pay for
this... :-/
https://codereview.chromium.org/920993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
10 matches
Mail list logo
