[v8-dev] Re: Fix for constant pool support and debug (issue 430523002 by andrew_...@ca.ibm.com)

2014-07-30 Thread rmcilroy
Committed patchset #2 manually as r22701 (presubmit successful). https://codereview.chromium.org/430523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Fix for constant pool support and debug (issue 430523002 by andrew_...@ca.ibm.com)

2014-07-30 Thread rmcilroy
On 2014/07/30 09:47:01, danno wrote: Ross, could you please take a look at this and land it for Andrew? lgtm, thanks. I'll land this with a slight change (moving the setting to be above setting the pc). https://codereview.chromium.org/430523002/ -- -- v8-dev mailing list v8-dev@googlegroups.

[v8-dev] Re: Fix for constant pool support and debug (issue 430523002 by andrew_...@ca.ibm.com)

2014-07-30 Thread danno
Ross, could you please take a look at this and land it for Andrew? https://codereview.chromium.org/430523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] Re: Fix for constant pool support and debug (issue 430523002 by andrew_...@ca.ibm.com)

2014-07-29 Thread andrew_low
Apologies for churn - still learning the commit / review flow. https://codereview.chromium.org/430523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To uns

[v8-dev] Re: Fix for constant pool support and debug (issue 430523002 by andrew_...@ca.ibm.com)

2014-07-29 Thread andrew_low
Out of line constant pool patch. My PowerPC port uses constant pools and without this change, debug is broken. https://codereview.chromium.org/430523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc