[v8-dev] Re: Fix issue 267: Functions now called with global object as receiver.

2009-03-10 Thread ager
LGTM http://codereview.chromium.org/42009 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Fix issue 267: Functions now called with global object as receiver.

2009-03-10 Thread kmillikin
http://codereview.chromium.org/42009/diff/10/13 File src/codegen-ia32.cc (right): http://codereview.chromium.org/42009/diff/10/13#newcode3920 Line 3920: frame_->SpillAll(); I know it's not your code, but you could try getting rid of the SpillAll here and changing the EmitPush to PushElementAt, j

[v8-dev] Re: Fix issue 267: Functions now called with global object as receiver.

2009-03-10 Thread lrn
http://codereview.chromium.org/42009/diff/10/13 File src/codegen-ia32.cc (right): http://codereview.chromium.org/42009/diff/10/13#newcode3920 Line 3920: frame_->SpillAll(); Done. http://codereview.chromium.org/42009 --~--~-~--~~~---~--~~ v8-dev mailing list v8-d