[v8-dev] Re: Fix lint issues found by tools/presubmit.py.

2009-02-26 Thread mikhail . naganov
LGTM http://codereview.chromium.org/28178 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Fix lint issues....

2008-11-06 Thread christian . plesner . hansen
Lookin' good. http://codereview.chromium.org/9457/diff/1/8 File src/assembler-re2k.h (right): http://codereview.chromium.org/9457/diff/1/8#newcode76 Line 76: // Checks a register for equal, less than or equal, less than, greater than We only need two of these, LT and GEQ. http://codereview.chr

[v8-dev] Re: Fix lint issues.

2008-10-28 Thread Feng Qian
lgtm, thanks On Tue, Oct 28, 2008 at 7:54 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Feng Qian, > > Description: > Fix lint issues. > > [EMAIL PROTECTED] > > Please review this at http://codereview.chromium.org/8659 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected

[v8-dev] Re: Fix lint issues.

2008-09-18 Thread ager
LGTM http://codereview.chromium.org/3144 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---