[v8-dev] Re: Fix probably harmless thinko in StringCharAt (causes...

2009-03-10 Thread erik . corry
http://codereview.chromium.org/43005 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Fix probably harmless thinko in StringCharAt (causes...

2009-03-10 Thread lrn
http://codereview.chromium.org/43005/diff/1/2 File src/string.js (right): http://codereview.chromium.org/43005/diff/1/2#newcode65 Line 65: var subject = ToString(this); My bad. The real problem was ofcourse that subject was used before it was initialized. http://codereview.chromium.org/43005 -

[v8-dev] Re: Fix probably harmless thinko in StringCharAt (causes...

2009-03-10 Thread lrn
LGTM, if this is what you want. http://codereview.chromium.org/43005/diff/1/2 File src/string.js (right): http://codereview.chromium.org/43005/diff/1/2#newcode65 Line 65: var subject = ToString(this); This changes the behavior on non-string receivers to potentially use the fast case, but at the