[v8-dev] Re: Fix shared_library build after r17107 (issue 26004003)

2013-10-04 Thread rmcilroy
Thanks for looking into this. This works for the component build, but unfortunately now fails in the single lib chromium build. Possible solution inline. https://codereview.chromium.org/26004003/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/26004003/di

[v8-dev] Re: Fix shared_library build after r17107 (issue 26004003)

2013-10-04 Thread rmcilroy
lgtm As discussed offline, this does actually work. Thanks! https://codereview.chromium.org/26004003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsu

[v8-dev] Re: Fix shared_library build after r17107 (issue 26004003)

2013-10-04 Thread jkummerow
Committed patchset #1 manually as r17109. https://codereview.chromium.org/26004003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro