LGTM
http://codereview.chromium.org/2926/diff/4/204
File src/builtins-ia32.cc (right):
http://codereview.chromium.org/2926/diff/4/204#newcode527
Line 527: __ j(above, &no_preemption, taken);
void Ia32CodeGenerator::CheckStack() uses above_equal.
http://codereview.chromium.org/2926
--~--~-
http://codereview.chromium.org/2926
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Recording off-line discussion... -ip
http://codereview.chromium.org/2926/diff/1/2
File src/builtins-ia32.cc (right):
http://codereview.chromium.org/2926/diff/1/2#newcode532
Line 532: __ j(greater, &okay, taken);
This should be a signed compare in case the stack already went past the
stack_guar
