[v8-dev] Re: Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden proper...

2009-04-08 Thread asargent
http://codereview.chromium.org/58016/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/58016/diff/1/2#newcode2085 Line 2085: if (js_object->IsUndefined()) { On 2009/04/08 04:52:04, iposva wrote: > This test seems redundant. hidden_props has to be !undefined to reach here, and > th

[v8-dev] Re: Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden proper...

2009-04-07 Thread iposva
One comment, otherwise LGTM! Thanks, -Ivan http://codereview.chromium.org/58016/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/58016/diff/1/2#newcode2085 Line 2085: if (js_object->IsUndefined()) { This test seems redundant. hidden_props has to be !undefined to reach here, a