[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-14 Thread svenpanne
On 2013/10/12 08:23:16, Weiliang wrote: Hi Yang, extractps is not used in current V8. I found this bug when prototyping SIMD in V8. Of course, we could just delete extractps instruction, but from my view, I hope it could be kept there. Either we should fix it or remove the instruction, but

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-15 Thread weiliang . lin
On 2013/10/14 07:43:54, Sven Panne wrote: On 2013/10/12 08:23:16, Weiliang wrote: > Hi Yang, > extractps is not used in current V8. I found this bug when prototyping SIMD in > V8. Of course, we could just delete extractps instruction, but from my view, I > hope it could be kept there. Ei

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-15 Thread svenpanne
lgtm https://codereview.chromium.org/27097002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-15 Thread svenpanne
NOT LGTM, actually. :-/ This CL makes the test suite fail in debug mode due to missing CpuFeatureScopes and some IsSupported/IsEnabled confusion. I'll close this issue a re-upload a fixed one. https://codereview.chromium.org/27097002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-15 Thread weiliang . lin
On 2013/10/15 12:35:55, Sven Panne wrote: NOT LGTM, actually. :-/ This CL makes the test suite fail in debug mode due to missing CpuFeatureScopes and some IsSupported/IsEnabled confusion. I'll close this issue a re-upload a fixed one. Please try the new CL. :) https://codereview.chromium.o

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-16 Thread svenpanne
On 2013/10/16 00:22:59, Weiliang wrote: Please try the new CL. :) There seems to be a misunderstanding here: I landed https://code.google.com/p/v8/source/detail?r=17217 yesterday plus a follow-up fix https://code.google.com/p/v8/source/detail?r=17218. Is there anything to be done after the

[v8-dev] Re: Fixed bug in extractps instruction on ia32 and x64 (issue 27097002)

2013-10-16 Thread weiliang . lin
On 2013/10/16 07:21:34, Sven Panne wrote: On 2013/10/16 00:22:59, Weiliang wrote: > Please try the new CL. :) There seems to be a misunderstanding here: I landed https://code.google.com/p/v8/source/detail?r=17217 yesterday plus a follow-up fix https://code.google.com/p/v8/source/detail?r=172