[v8-dev] Re: Fixes for assumption of sizeof(int) == sizeof(void*)

2009-01-22 Thread Jeff Bailey
I'm certainly not expecting that type changes will magically make this code 64-bit clean. If that were true, it would've been done already. If it would be better, I can do these changes out of tree and come back with things when I have them working. My question from the previous email is whether

[v8-dev] Re: Fixes for assumption of sizeof(int) == sizeof(void*)

2009-01-22 Thread Dean McNamee
When we've discussed the v8 pointer/type situation before, it seemed like there would need to be some discussion on typedefs and style so that the types could really make sense internally for V8. It's hard, because there are pointers, pointers get tagged, they have certain bits used, and a lot of

[v8-dev] Re: Fixes for assumption of sizeof(int) == sizeof(void*)

2009-01-22 Thread Jeff Bailey
Thanks! On x86_64 without -m32, this becomes a problem (as it would on ia64, alpha, or other Debian architectures I might wind up porting this to). I've heard from others that 64 bit targets aren't really interesting to the V8 team, so I assume I'll keep keeping some fixes out of tree for now, b

[v8-dev] Re: Fixes for assumption of sizeof(int) == sizeof(void*)

2009-01-22 Thread Mads Sig Ager
Thanks for the patch! Using %p is the right thing here. It has been committed in V8 bleeding_edge revision 1128. :-) Do you have a build setup where this is a problem? If you do, we would be interested in more details of the setup so we can test against it. Cheers,-- Mads On Wed, Jan 2