[v8-dev] Re: Generate inline code for contextual loads. (issue3402014)

2010-09-19 Thread sgjesse
LGTM http://codereview.chromium.org/3402014/diff/1/5 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/3402014/diff/1/5#newcode9431 src/ia32/codegen-ia32.cc:9431: masm()->mov(result.reg(), Factory::null_value()); How about having a --debug-code guarded assert here that resul

[v8-dev] Re: Generate inline code for contextual loads. (issue3402014)

2010-09-20 Thread vitalyr
On 2010/09/20 06:50:08, Søren Gjesse wrote: LGTM Thanks! http://codereview.chromium.org/3402014/diff/1/5 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/3402014/diff/1/5#newcode9431 src/ia32/codegen-ia32.cc:9431: masm()->mov(result.reg(), Factory::null_value()); How