[v8-dev] Re: Graph node attribute printing.

2008-11-26 Thread Christian Plesner Hansen
Attached is an example. On Wed, Nov 26, 2008 at 3:08 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Erik Corry, > > Description: > Graph node attribute printing. > > Please review this at http://codereview.chromium.org/12471 > > Affected files: > M src/jsregexp.cc > M test/cctest/test-regexp.cc >

[v8-dev] Re: Graph node attribute printing.

2008-11-26 Thread erik . corry
Cool stuff. The bytecode tracing code works with hexadecimal program counters, so if the PC could be hex that would be ideal. http://codereview.chromium.org/12471 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-

[v8-dev] Re: Graph node attribute printing.

2008-11-26 Thread Christian Plesner Hansen
I've changed it to hex. On Wed, Nov 26, 2008 at 3:13 PM, <[EMAIL PROTECTED]> wrote: > Cool stuff. > > The bytecode tracing code works with hexadecimal program counters, so if > the PC could be hex that would be ideal. > > http://codereview.chromium.org/12471 > --~--~-~--~~--