LGTM if it works.
http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):
http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) ===
this.fun ||
Is __lookup[GS]etter__ safe to use, or can it be changed by the
Please take another look, hopefully this is less fragile.
http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):
http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) ===
this.fun ||
On 2010/08/10 08:29:38,
LGTM
http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):
http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) ===
this.fun ||
ObjectLookupGetter.call(this.receiver, ownName)
ObjectLookupSetter.call(thi
On 2010/08/13 07:03:21, Lasse Reichstein wrote:
LGTM
http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):
http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) === this.fun
||
> ObjectLookupGetter.
Yes, it should be changed, and we need an %_ApplyFunction as well.
/L
On Fri, Aug 13, 2010 at 10:31, wrote:
> On 2010/08/13 07:03:21, Lasse Reichstein wrote:
>
>> LGTM
>>
>
> http://codereview.chromium.org/3082012/diff/1/2
>> File src/messages.js (right):
>>
>
> http://codereview.chromium.org
http://code.google.com/p/v8/issues/detail?id=828
On Fri, Aug 13, 2010 at 10:38, Lasse R.H. Nielsen wrote:
> Yes, it should be changed, and we need an %_ApplyFunction as well.
>
> /L
>
>
> On Fri, Aug 13, 2010 at 10:31, wrote:
>
>> On 2010/08/13 07:03:21, Lasse Reichstein wrote:
>>
>>> LGTM
>>>
