Committed patchset #3 manually as r20795 (presubmit successful).
https://codereview.chromium.org/235153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/235153003/diff/20001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/235153003/diff/20001/src/factory.h#newcode417
src/factory.h:417: // by containing this pointer.
On 2014/04/16 11:10:04, Michael Starzinger wrote:
nit: s/this pointer/th
On 2014/04/16 11:25:39, Michael Starzinger wrote:
Comment from offline discussion.
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
src/heap.cc:3874: code->set_ic_age(globa
Comment from offline discussion.
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
src/heap.cc:3874: code->set_ic_age(global_ic_age_);
As per offline discussion: Let's also move
LGTM, just nits.
https://codereview.chromium.org/235153003/diff/20001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/235153003/diff/20001/src/factory.h#newcode417
src/factory.h:417: // by containing this pointer.
nit: s/this pointer/this handle/
https://codereview.ch
On 2014/04/11 13:15:38, Yang wrote:
*creeping up behind your shoulder*
https://codereview.chromium.org/235153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group
