[v8-dev] Re: Implement "wait for connection" feature (issue489005)

2009-12-11 Thread peter . rybin
http://codereview.chromium.org/489005/diff/3001/4003 File src/debug.cc (right): http://codereview.chromium.org/489005/diff/3001/4003#newcode2487 src/debug.cc:2487: // Simply ignore message. On 2009/12/11 09:45:52, Søren Gjesse wrote: > Maybe this should be extended to keep all messages (or block

[v8-dev] Re: Implement "wait for connection" feature (issue489005)

2009-12-11 Thread sgjesse
LGTM http://codereview.chromium.org/489005/diff/3001/4003 File src/debug.cc (right): http://codereview.chromium.org/489005/diff/3001/4003#newcode2487 src/debug.cc:2487: // Simply ignore message. Maybe this should be extended to keep all messages (or block on the first) for the debugger when it c

[v8-dev] Re: Implement "wait for connection" feature (issue489005)

2009-12-11 Thread Søren Gjesse
Yes, v8::Debug::DebugBreak() will set the flag. /Søren On Thu, Dec 10, 2009 at 23:04, wrote: > > Should the debug break flag be raised to >> > ensure that a break will happen as soon as any code is executed? >> I didn't think about this. I though about manually putting "debugger;" >> > statemen

[v8-dev] Re: Implement "wait for connection" feature (issue489005)

2009-12-10 Thread peter . rybin
> > Should the debug break flag be raised to > > ensure that a break will happen as soon as any code is executed? > I didn't think about this. I though about manually putting "debugger;" statement > in the beginning of program. > Probably I should try to with this runtime flag. Can I do this just