Thanks Lasse. Ulan and I just found out by looking at GCC-compiled code of
tan(). There are a few other places where "ffree(); fincstp()" could be
replaced. Will be addressed in another CL though.
Yang
On Fri, Nov 25, 2011 at 2:11 PM, wrote:
> LGTM if Lasse's comment is addressed.
>
>
> http://
LGTM if Lasse's comment is addressed.
http://codereview.chromium.org/874/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/874/diff/1/src/arm/full-codegen-arm.cc#newcode3142
src/arm/full-codegen-arm.cc:3142: context()->Plug(r0);
drive-by comment.
http://codereview.chromium.org/874/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
http://codereview.chromium.org/874/diff/1/src/x64/code-stubs-x64.cc#newcode1781
src/x64/code-stubs-x64.cc:1781: __ fincstp();
If you just want to drop the top el
