[v8-dev] Re: Improve write barriers in optimized code. (issue 297763006)

2014-06-03 Thread bmeurer
https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc#newcode517 src/arm/macro-assembler-arm.cc:517: // TODO(mstarzinger): Dynamic

[v8-dev] Re: Improve write barriers in optimized code. (issue 297763006)

2014-06-03 Thread hpayer
lgtm https://codereview.chromium.org/297763006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Improve write barriers in optimized code. (issue 297763006)

2014-06-03 Thread bmeurer
Committed patchset #5 manually as r21630 (tree was closed). https://codereview.chromium.org/297763006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Improve write barriers in optimized code. (issue 297763006)

2014-06-02 Thread hpayer
I like it! Just nits... I am waiting for the ports. https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc#newcode517