[v8-dev] Re: In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler.

2008-09-22 Thread Kasper Lund
LGTM. If you want to save even more space you could have a specialized version of V8_Fatal -- called V8_Unimplemented or something -- that doesn't take any parameters. We should also fix the naming of V8_Fatal -- why is there an underscore in it? Weird... On Sat, Sep 20, 2008 at 7:24 PM, <[EMAIL

[v8-dev] Re: In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler.

2008-09-22 Thread iposva
I do like the UNREACHABLE because it signals that something went really wrong. But I am not sure if it is more useful than an ASSERT. I do like Kasper's suggestion to simplifying the UNIMPLEMENTED call's implementation. http://codereview.chromium.org/4008 --~--~-~--~~~--