[v8-dev] Re: Increase coverage testing of sparse arrays. Add a set...

2009-04-07 Thread iposva
Comments below, otherwise LGTM. -Ivan http://codereview.chromium.org/63100/diff/1/3 File test/mjsunit/array-shift.js (right): http://codereview.chromium.org/63100/diff/1/3#newcode29 Line 29: arr = [1, 2, 3, 4, 5]; The fact that the array indices and the values do not line up is rather confus

[v8-dev] Re: Increase coverage testing of sparse arrays. Add a set...

2009-04-08 Thread mbelshe
http://codereview.chromium.org/63100/diff/1/3 File test/mjsunit/array-shift.js (right): http://codereview.chromium.org/63100/diff/1/3#newcode29 Line 29: arr = [1, 2, 3, 4, 5]; On 2009/04/08 01:01:18, iposva wrote: > The fact that the array indices and the values do not line up is rather > confus