[v8-dev] Re: Initial Solaris support (issue545125)

2010-01-25 Thread Mads Sig Ager
Whoops, comitted in revision 3693. -- Mads On Mon, Jan 25, 2010 at 5:42 PM, Ryan Dahl wrote: >> Thanks for the patch.  Landed in V8 bleeding_edge revision 3688. > > It seems platform-solaris.cc did not get included? > -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/grou

[v8-dev] Re: Initial Solaris support (issue545125)

2010-01-25 Thread Ryan Dahl
> Thanks for the patch. Landed in V8 bleeding_edge revision 3688. It seems platform-solaris.cc did not get included? -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Initial Solaris support (issue545125)

2010-01-25 Thread ager
Thanks for the patch. Landed in V8 bleeding_edge revision 3688. http://codereview.chromium.org/545125 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Initial Solaris support (issue545125)

2010-01-21 Thread coldredlemur
http://codereview.chromium.org/545125/diff/1/10 File src/platform-solaris.cc (right): http://codereview.chromium.org/545125/diff/1/10#newcode29 src/platform-solaris.cc:29: // parts the implementation is in platform-posix.cc. On 2010/01/21 09:58:08, Erik Corry wrote: Please add a comment to the

[v8-dev] Re: Initial Solaris support (issue545125)

2010-01-21 Thread erik . corry
Thanks for this. It needs a few fixes before we can commit it. http://codereview.chromium.org/545125/diff/1/10 File src/platform-solaris.cc (right): http://codereview.chromium.org/545125/diff/1/10#newcode29 src/platform-solaris.cc:29: // parts the implementation is in platform-posix.cc. Please