[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-24 Thread titzer
Committed patchset #12 manually as r14791 (presubmit successful). https://codereview.chromium.org/14284010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-15 Thread danno
lgtm if there are no regressions on the big three benchmarks https://codereview.chromium.org/14284010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-15 Thread titzer
On 2013/05/15 09:15:30, danno wrote: https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h#newcode5267 src/hydrogen-instructions.h:5267: unsigne

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-15 Thread Ben L. Titzer
On Wed, May 15, 2013 at 11:15 AM, wrote: > > https://codereview.chromium.**org/14284010/diff/56001/src/** > hydrogen-instructions.h > File src/hydrogen-instructions.h (right): > > https://codereview.chromium.**org/14

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-15 Thread danno
https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h#newcode5267 src/hydrogen-instructions.h:5267: unsigned portion_ : 4; I think you misinterprete

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-14 Thread titzer
On 2013/05/14 14:41:58, danno wrote: https://codereview.chromium.org/14284010/diff/50001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/50001/src/hydrogen-instructions.h#newcode5286 src/hydrogen-instructions.h:5286: unsigne

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-14 Thread danno
https://codereview.chromium.org/14284010/diff/50001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/50001/src/hydrogen-instructions.h#newcode5286 src/hydrogen-instructions.h:5286: unsigned portion_ : 3; Can't you just make this

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-14 Thread titzer
https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc#newcode3633 src/hydrogen-instructions.cc:3633: return HObjectAccess(kInobject, offset); On

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-13 Thread danno
https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc#newcode3633 src/hydrogen-instructions.cc:3633: return HObjectAccess(kInobject, offset); OK,

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-13 Thread titzer
https://codereview.chromium.org/14284010/diff/35001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/35001/src/hydrogen-instructions.cc#newcode3637 src/hydrogen-instructions.cc:3637: return HObjectAccess(kInobject, offset); On

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-10 Thread danno
https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/39001/src/hydrogen-instructions.cc#newcode3633 src/hydrogen-instructions.cc:3633: return HObjectAccess(kInobject, offset); How

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-08 Thread danno
Very close... https://codereview.chromium.org/14284010/diff/35001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/35001/src/hydrogen-instructions.cc#newcode3637 src/hydrogen-instructions.cc:3637: return HObjectAccess(kInobjec

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-08 Thread titzer
https://codereview.chromium.org/14284010/diff/28001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/28001/src/hydrogen-instructions.cc#newcode3645 src/hydrogen-instructions.cc:3645: portion = kArrayLengths; // XXX: only true

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-08 Thread danno
I'll come by in person to discuss some of this. https://codereview.chromium.org/14284010/diff/28001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14284010/diff/28001/src/hydrogen-instructions.cc#newcode3645 src/hydrogen-instructions.cc:3

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-07 Thread titzer
https://codereview.chromium.org/14284010/diff/17001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/17001/src/hydrogen-instructions.h#newcode5228 src/hydrogen-instructions.h:5228: // internal use only; different parts of an obje

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-07 Thread titzer
https://codereview.chromium.org/14284010/diff/17001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (left): https://codereview.chromium.org/14284010/diff/17001/src/hydrogen-instructions.cc#oldcode3653 src/hydrogen-instructions.cc:3653: On 2013/05/06 15:53:06, danno wrote: Stray w

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-06 Thread danno
Getting pretty close, I really like the direction this is going. https://codereview.chromium.org/14284010/diff/17001/.gitignore File .gitignore (right): https://codereview.chromium.org/14284010/diff/17001/.gitignore#newcode27 .gitignore:27: bsuite Put this in a separate CL. https://codereview.

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-03 Thread titzer
https://codereview.chromium.org/14284010/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/14284010/diff/1/src/hydrogen.h#newcode1022 src/hydrogen.h:1022: ObjectAccess AccessArray(int offset); On 2013/05/02 14:16:47, danno wrote: Tricky/non-trick is an arbitrary

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-05-02 Thread danno
https://codereview.chromium.org/14284010/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/1/src/hydrogen-instructions.h#newcode5312 src/hydrogen-instructions.h:5312: Handle name_; You didn't address this comment. Why not?

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

2013-04-30 Thread titzer
https://codereview.chromium.org/14284010/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/14284010/diff/1/src/code-stubs-hydrogen.cc#newcode371 src/code-stubs-hydrogen.cc:371: ObjectAccess access = AccessInobject(factory->empty_string(),