Committed patchset #7 manually as r20457 (presubmit successful).
https://codereview.chromium.org/222163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/222163002/diff/11/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/11/src/handles.h#newcode108
src/handles.h:108: INLINE(Handle()) : location_(NULL) {}
Extra space before {}
https://codereview.chromium.org/
drive-by-comment
https://codereview.chromium.org/222163002/diff/20001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode88
src/handles.h:88: class Handle : public MaybeHandle {
I find it pretty confusing that a "checked handle" i
Drive-by comments.
https://codereview.chromium.org/222163002/diff/20001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode38
src/handles.h:38: class MaybeHandle {
Can we get a few comments above this class about why we have it an
