danno, thanks a lot for the review. I tried to add StackArgumentsAccessor
in the
code.h, there are two issues to address:
1) abstract stack_pointer, it seems that all the platforms have their own
rsp/esp/sp pointer, this issue is easy to solve.
2) abstract two addressing modes, "sp + reg*sca
danno, thanks for the review. I am glad you like this direction. The
comment is
addressed. I will work on https://codereview.chromium.org/22267005/ to use
the
StackArgumentsAccessor interface after this CL is landed.
https://codereview.chromium.org/21123008/
--
--
v8-dev mailing list
v8-dev@
lgtm if you address the nits, but please wait to land until we've opened the
tree again after this week's stability.
https://codereview.chromium.org/21123008/diff/49001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/21123008/diff/49001/src/x64/
danno, thanks for the review. I will wait and commit this when the tree is
open.
https://codereview.chromium.org/21123008/diff/49001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/21123008/diff/49001/src/x64/code-stubs-x64.cc#newcode2464
src/
Committed patchset #11 manually as r16345 (presubmit successful).
https://codereview.chromium.org/21123008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
