LGTM On Mon, Dec 8, 2008 at 10:31 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Lasse Reichstein, > > Description: > Irregexp (bytecodes) don't forget to update current position > on a no-case successful backref. > > Please review this at http://codereview.chromium.org/13615 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/interpreter-irregexp.cc > > > Index: src/interpreter-irregexp.cc > =================================================================== > --- src/interpreter-irregexp.cc (revision 930) > +++ src/interpreter-irregexp.cc (working copy) > @@ -381,6 +381,7 @@ > break; > } else { > if (BackRefMatchesNoCase(from, current, len, subject)) { > + current += len; > pc += BC_CHECK_NOT_BACK_REF_NO_CASE_LENGTH; > } else { > pc = code_base + Load32(pc + 2); > > >
-- Lasse R.H. Nielsen [EMAIL PROTECTED] 'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
