Comment #21 on issue 4387 by m.go...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Node.js 4.0.0 is going to come out with V8 4.5 after all, the initial
release is coming soon so it will have buggy computed props. If this
Updates:
Labels: merge-merged-4.6
Comment #20 on issue 4387 by bugdro...@chromium.org: Computed property
names don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387#c20
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.gi
Updates:
Labels: -Merge-Request-4.6 Merge-approved-4.6 merge-TBD-4.5
Comment #19 on issue 4387 by habl...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
(No comment was entered for this change.)
--
You received t
Comment #18 on issue 4387 by ad...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Per offline discussion, we'll likely ask to merge this into 4.5 for a
future stable release after it gets more coverage in canary/4.6.
Updates:
Status: Fixed
Labels: Merge-Request-4.6
Comment #17 on issue 4387 by ad...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
This is probably worth merging to 4.6, even if it's too late for 4.5.
--
Comment #16 on issue 4387 by bugdro...@chromium.org: Computed property
names don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387#c16
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/233d62f8e306e56d5ed0597b008c205700e744
Comment #15 on issue 4387 by m.go...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Re #14: Ah, ok then, nothing to backport for the Node sake then; maybe
they'll patch it on their side if the fix is a one-liner.
For ref
Comment #14 on issue 4387 by mic.bes...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Node.js 4 will be using V8 4.4, not 4.5
--
You received this message because this project is configured to send all
issue notification
Comment #13 on issue 4387 by m.go...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Since this has already shipped and the fix seems to be a one-liner, will
you backport it to v4.5? This will be the V8 used in the upcoming
Comment #12 on issue 4387 by kozyatins...@chromium.org: Computed property
names don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
Issue chromium:522519 has been merged into this issue.
--
You received this message because this project is configured to send all
Comment #11 on issue 4387 by zaxxon2...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
I'm not disagreeing with you. If you believe the third option is more
correct, by all means go for it. I'm happy to see this bug fixed
Comment #10 on issue 4387 by ad...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
IsBoilerplateProperty() only makes sense on properties whose index is less
than the first property with a computed name. Agreed that this
Comment #9 on issue 4387 by zaxxon2...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
If you go with the third option, please consider renaming
IsBoilerplateProperty(), as it does not mean what its name implies if it
all
Comment #8 on issue 4387 by ad...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
https://codereview.chromium.org/1307943007/
--
You received this message because this project is configured to send all
issue notificatio
Comment #7 on issue 4387 by ad...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
A third option, I think this is actually the right fix:
--- a/src/ast.cc
+++ b/src/ast.cc
@@ -446,6 +446,7 @@ void ObjectLiteral::BuildCon
Comment #6 on issue 4387 by caitpott...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
That may be a better approach to fixing than https://crrev.com/1307223002
-- reviewers can pick their favorite
--
You received this m
Comment #5 on issue 4387 by zaxxon2...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
I had some success with this. I didn't try "make check".
--- v8/src/ast.cc.orig 2015-08-24 13:18:35.598224718 -0400
+++ v8/src/ast.cc
Comment #4 on issue 4387 by caitpott...@gmail.com: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
It looks like the number of boilerplate properties is kept at 0 when
computed properties are used. Apparently this is only a problem fo
Updates:
Status: Assigned
Comment #3 on issue 4387 by rossb...@chromium.org: Computed property names
don't work in nested literals
https://code.google.com/p/v8/issues/detail?id=4387
(No comment was entered for this change.)
--
You received this message because this project is configu
Updates:
Summary: Computed property names don't work in nested literals
Owner: ad...@chromium.org
Cc: rossb...@chromium.org mstarzin...@chromium.org
Labels: -Priority-Medium Priority-High
Comment #2 on issue 4387 by rossb...@chromium.org: Computed property names
20 matches
Mail list logo
