[v8-dev] Re: Lazily initialize the target map list in IC. (issue 220923003)

2014-04-02 Thread ulan
Committed patchset #1 manually as r20426 (presubmit successful). https://codereview.chromium.org/220923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Lazily initialize the target map list in IC. (issue 220923003)

2014-04-01 Thread verwaest
https://codereview.chromium.org/220923003/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/220923003/diff/1/src/ic.cc#newcode1426 src/ic.cc:1426: if (target_receiver_maps.length() == 0) { length() == 0 isn't the same as UNINITIALIZED || PREMONOMORPHIC. We could also have

[v8-dev] Re: Lazily initialize the target map list in IC. (issue 220923003)

2014-04-01 Thread ulan
https://codereview.chromium.org/220923003/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/220923003/diff/1/src/ic.cc#newcode1426 src/ic.cc:1426: if (target_receiver_maps.length() == 0) { On 2014/04/01 15:22:05, Toon Verwaest wrote: length() == 0 isn't the same as

[v8-dev] Re: Lazily initialize the target map list in IC. (issue 220923003)

2014-04-01 Thread verwaest
lgtm https://codereview.chromium.org/220923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from