[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

Of course t2 is just clobbered, and knowing runtime call sets count to 0 lets us avoid reloading it. https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to t

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

On 2014/05/23 18:10:19, Igor Sheludko wrote: t2 must be set to zero here (which is JSFunction::kNoSlackTracking) since the slack tracking is actually over after the runtime call. Not sure if t7 survives after the runtime call above. Yep, t7 would get clobbered, and I not understand Runtime

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

Sorry for being late, but... https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc#newcode401 src/mips/builtins-mips.cc:401: __ Pop(a1, a2); t2 must be

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

Committed as r21470. https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

lgtm https://codereview.chromium.org/294973013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390 src/mips/builtins-mips.cc:390: __ DecodeField(a3, t0); On 2014/05/23 15:33:39, Paul Lind wrote:

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

Thanks for detailed review Igor! https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390 src/mips/builtins-mips.cc:390: __ DecodeField(a3, t0); On 201

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390 src/mips/builtins-mips.cc:390: __ DecodeField(a3, t0); What do you think about storing decoded

[v8-dev] Re: MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared i... (issue 294973013)

One comment, PTAL https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode440 src/mips/builtins-mips.cc:440: Label no_inobject_slack_tracking; The deleted