Largish review.
http://codereview.chromium.org/42441
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/42441/diff/1008/1009
File src/jsregexp.cc (right):
http://codereview.chromium.org/42441/diff/1008/1009#newcode605
Line 605: previous_index);
A comment would be in order here!
http://codereview.chromium.org/42441/diff/1008/1010
File src/jsregexp.h (right):
h
Addressed issues except:
http://codereview.chromium.org/42441/diff/1008/1013
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/42441/diff/1008/1013#newcode5745
Line 5745: const char* c_source =
Are they more likely to fail?
In any case, that would be another test case, since
This change seems to have caused a fairly big performance regression
on arm. Before this change the longest running test took just over a
minute, after this change 48 tests time out because they take over two
minutes.
On Sat, Mar 21, 2009 at 12:26 AM, wrote:
>
> Addressed issues except:
>
>
>
They actually hang completely. The interpreter was borked (forgot to compile
the regexp, and was treating TheHole as a ByteArray). It's a wonder it
didn't crash.
Should be fixed now.
/L
On Mon, Mar 23, 2009 at 12:51 AM, Christian Plesner Hansen <
christian.plesner.han...@gmail.com> wrote:
> Thi
