LGTM -ip
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Done.
On 2009/05/06 18:20:05, iposva wrote:
> http://codereview.chromium.org/113035/diff/1002/1003
> File src/api.cc (right):
> http://codereview.chromium.org/113035/diff/1002/1003#newcode211
> Line 211: if (IsDeadCheck(location)) return;
> This optimization will not work because the IsDeadCheck
http://codereview.chromium.org/113035/diff/1002/1003
File src/api.cc (right):
http://codereview.chromium.org/113035/diff/1002/1003#newcode211
Line 211: if (IsDeadCheck(location)) return;
This optimization will not work because the IsDeadCheck is supposed to
guard against a V8 that has been initi
Done
On 2009/05/06 18:04:44, iposva wrote:
> Please update the documentation in include/v8.h as well.
> -Ivan
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~---
I also added a change to cache whether we're initialized, allowing us to
inline that and avoid the deadchecks when we are.
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Please update the documentation in include/v8.h as well.
-Ivan
http://codereview.chromium.org/113035
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
