[v8-dev] Re: Make invalid LHSs that are calls late errors (issue 217823003)

(still lgtm) https://codereview.chromium.org/217823003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Make invalid LHSs that are calls late errors (issue 217823003)

Committed patchset #2 manually as r20428 (presubmit successful). https://codereview.chromium.org/217823003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Make invalid LHSs that are calls late errors (issue 217823003)

lgtm modulo comments... https://codereview.chromium.org/217823003/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/217823003/diff/1/src/parser.cc#newcode3031 src/parser.cc:3031: if (expression == NULL) { I don't think that expression can be NULL here. Afaics the

[v8-dev] Re: Make invalid LHSs that are calls late errors (issue 217823003)

https://codereview.chromium.org/217823003/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/217823003/diff/1/src/parser.cc#newcode3031 src/parser.cc:3031: if (expression == NULL) { On 2014/04/01 16:13:47, marja wrote: I don't think that expression can be NULL