On 2015/05/08 01:13:34, adamk wrote:
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newcode158
src/typedarray.js:158: function TypedArraySubArray(begin, end) {
We
lgtm % arv's comments
On 2015/05/08 19:46:06, dehrenberg wrote:
On 2015/05/08 01:13:34, adamk wrote:
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newcode158
I'm not too concerned about compat. Adding another object to the
prototype doesn't change the interface. It will break code that does
hasOwnProperty but I don't think it is common for these things.
On Fri, May 8, 2015 at 4:07 PM, ad...@chromium.org wrote:
lgtm % arv's comments
On 2015/05/08
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1126313003/80001
https://codereview.chromium.org/1126313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1126313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 5 (id:??) landed as
https://crrev.com/ca9d499f75b3557840f82f1ad172afdb514ce2d1
Cr-Commit-Position: refs/heads/master@{#28325}
https://codereview.chromium.org/1126313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1126313003/diff/60001/test/mjsunit/harmony/typedarray-proto.js
File test/mjsunit/harmony/typedarray-proto.js (right):
https://codereview.chromium.org/1126313003/diff/60001/test/mjsunit/harmony/typedarray-proto.js#newcode40
Reviewers: adamk, arv, caitp, Dmitry Lomov (chromium), jochen,
Message:
Done
Description:
Make one copy for all TypedArray methods
This is the first step of converting TypedArrays to the proper
proto chain. There is one copy for each of the Harmony TypedArray
methods, rather than a version for
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newcode158
src/typedarray.js:158: function TypedArraySubArray(begin, end) {
We probably want to change this in the
