[v8-dev] Re: Make sure value is a heap number when reusing the double box in BinaryOpICStub. (issue 216823005)

2014-04-04 Thread verwaest
This fix fixes the mutation problem, however it does not fix the double-run problem afaict. It could be that the operand is indeed a number, but that the second operand which used to be a number, is now a string. That would cause a deopt due to string->number conversion while trying to save, c

[v8-dev] Re: Make sure value is a heap number when reusing the double box in BinaryOpICStub. (issue 216823005)

2014-04-04 Thread hpayer
Committed patchset #1 manually as r20501 (presubmit successful). https://codereview.chromium.org/216823005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Make sure value is a heap number when reusing the double box in BinaryOpICStub. (issue 216823005)

2014-04-04 Thread mstarzinger
LGTM. https://codereview.chromium.org/216823005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i