[v8-dev] Re: Mark all loop conditions. (issue1074009)

http://codereview.chromium.org/1074009/diff/4001/5003 File src/data-flow.cc (right): http://codereview.chromium.org/1074009/diff/4001/5003#newcode223 src/data-flow.cc:223: cond_copy->set_is_loop_condition(false); On 2010/03/23 13:21:02, Søren Gjesse wrote: Strictly speaking this is a lie, and i

[v8-dev] Re: Mark all loop conditions. (issue1074009)

LGTM http://codereview.chromium.org/1074009/diff/4001/5003 File src/data-flow.cc (right): http://codereview.chromium.org/1074009/diff/4001/5003#newcode223 src/data-flow.cc:223: cond_copy->set_is_loop_condition(false); Strictly speaking this is a lie, and it will cause the number compare code to

[v8-dev] Re: Mark all loop conditions. (issue1074009)

LGTM. http://codereview.chromium.org/1074009/diff/4001/5004 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1074009/diff/4001/5004#newcode2475 src/ia32/codegen-ia32.cc:2475: bool is_loop_condition = (node->AsExpression() != NULL) && I think we should change CodeGenerator::