LGTM

http://codereview.chromium.org/1094014/diff/1/33
File src/SConscript (right):

http://codereview.chromium.org/1094014/diff/1/33#newcode260
src/SConscript:260: debug-debugger.js
We will break the other builds unless we do this other places too.

http://codereview.chromium.org/1094014/diff/1/54
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/1094014/diff/1/54#newcode926
src/arm/stub-cache-arm.cc:926: if (false &&
function_info->HasCustomCallGenerator()) {
I will fix this ASAP.

http://codereview.chromium.org/1094014/diff/1/37
File src/debug.cc (right):

http://codereview.chromium.org/1094014/diff/1/37#newcode721
src/debug.cc:721: // Mark this script as native and return successfully.
??

http://codereview.chromium.org/1094014/diff/1/20
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/1094014/diff/1/20#newcode1457
src/ia32/stub-cache-ia32.cc:1457: if (false &&
function_info->HasCustomCallGenerator()) {
Note.

http://codereview.chromium.org/1094014/diff/1/38
File src/mksnapshot.cc (right):

http://codereview.chromium.org/1094014/diff/1/38#newcode102
src/mksnapshot.cc:102: partial_sink_(this) {
This one may trigger a warning on Windows...

http://codereview.chromium.org/1094014/diff/1/46
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/1094014/diff/1/46#newcode786
src/x64/stub-cache-x64.cc:786: if (false &&
function_info->HasCustomCallGenerator()) {
Note to self...

http://codereview.chromium.org/1094014

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply 
to this email with the words "REMOVE ME" as the subject.

Reply via email to