[v8-dev] Re: Minor adjustments to the object migration code: When copying...

2008-10-08 Thread Kevin Millikin
LGTM. On Wed, Oct 8, 2008 at 10:31 AM, <[EMAIL PROTECTED]> wrote: > > Reviewers: Kevin Millikin, > > Description: > Minor adjustments to the object migration code: When copying > large objects we use memcpy. If this turns out to be a wash > on the benchmarks, I'd be happy to rip it out again. > >

[v8-dev] Re: Minor adjustments to the object migration code: When copying...

2008-10-08 Thread Dean McNamee
Won't memcpy always be an inlined intrinsic? On Wed, Oct 8, 2008 at 10:38 AM, Kevin Millikin <[EMAIL PROTECTED]> wrote: > LGTM. > > On Wed, Oct 8, 2008 at 10:31 AM, <[EMAIL PROTECTED]> wrote: >> >> Reviewers: Kevin Millikin, >> >> Description: >> Minor adjustments to the object migration code: Wh

[v8-dev] Re: Minor adjustments to the object migration code: When copying...

2008-10-08 Thread Dean McNamee
-minline-all-stringops By default GCC inlines string operations only when destination is known to be aligned at least to 4 byte boundary. This enables more inlining, increase code size, but may improve performance of code that depends on fast memc

[v8-dev] Re: Minor adjustments to the object migration code: When copying...

2008-10-08 Thread Erik Corry
On Wed, Oct 8, 2008 at 12:10 PM, Dean McNamee <[EMAIL PROTECTED]> wrote: > > Won't memcpy always be an inlined intrinsic? Not with variable size: $ cat copy.cc #include extern void foo(char* a, char* b, int size) { memcpy(a, b, size); } $ g++ -S -O3 copy.cc $ cat copy.s .file "copy.cc"