LGTM On Mon, Mar 9, 2009 at 9:30 AM, <a...@chromium.org> wrote:
> Reviewers: Søren Gjesse, > > Description: > Minor changes to allow V8 to build on Ubuntu Jaunty. > > Please review this at http://codereview.chromium.org/40289 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/assembler-ia32-inl.h > M src/heap-inl.h > > > Index: src/heap-inl.h > =================================================================== > --- src/heap-inl.h (revision 1441) > +++ src/heap-inl.h (working copy) > @@ -262,7 +262,7 @@ > > > #define CALL_HEAP_FUNCTION_VOID(FUNCTION_CALL) \ > - CALL_AND_RETRY(FUNCTION_CALL, , ) > + CALL_AND_RETRY(FUNCTION_CALL, ;, ;) > > > #ifdef DEBUG > Index: src/assembler-ia32-inl.h > =================================================================== > --- src/assembler-ia32-inl.h (revision 1441) > +++ src/assembler-ia32-inl.h (working copy) > @@ -279,7 +279,8 @@ > > void Operand::set_dispr(int32_t disp, RelocInfo::Mode rmode) { > ASSERT(len_ == 1 || len_ == 2); > - *reinterpret_cast<int32_t*>(&buf_[len_]) = disp; > + int32_t* p = reinterpret_cast<int32_t*>(&buf_[len_]); > + *p = disp; > len_ += sizeof(int32_t); > rmode_ = rmode; > } > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
