[v8-dev] Re: Move InitLineEnds and GetLineNumber to handles.cc to avoid...

2009-03-10 Thread ager
LGTM http://codereview.chromium.org/43020/diff/1/3 File src/handles.cc (right): http://codereview.chromium.org/43020/diff/1/3#newcode189 Line 189: CALL_HEAP_FUNCTION_VOID(string->TryFlattenIfNotFlat(StringShape(*string))); I think this change makes the code much clearer (and I think we should g

[v8-dev] Re: Move InitLineEnds and GetLineNumber to handles.cc to avoid...

2009-03-10 Thread mikhail . naganov
LGTM http://codereview.chromium.org/43020 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---