Committed patchset #4 manually as r14228 (presubmit successful).
https://codereview.chromium.org/14125004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/14125004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Comments addressed.
https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
On 2013/04/11 12:02:29, rossberg wrote:
https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
Actually, I think this should be split up into SetUpSet, SetUp
https://codereview.chromium.org/14125004/diff/1013/src/proxy.js
File src/proxy.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/proxy.js#newcode198
src/proxy.js:198: function SetUpProxy() {
I don't like separating this from the method definitions, I think it
should go before th
